wchevreuil commented on a change in pull request #3232:
URL: https://github.com/apache/hbase/pull/3232#discussion_r628068697
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
##########
@@ -135,9 +135,7 @@ public CellWritableComparable(Cell kv) {
@Override
public void write(DataOutput out) throws IOException {
- out.writeInt(PrivateCellUtil.estimatedSerializedSizeOfKey(kv));
- out.writeInt(0);
- PrivateCellUtil.writeFlatKey(kv, out);
+ KeyValueUtil.write(new KeyValue(kv), out);
Review comment:
You are basically reverting changes from commit
0a24178d06ac3dd5780522d52b5054e7aff1e50f from 4 years ago (HBASE-18649). Can
you get rid of that exception if you just remove the `out.writeInt(0)` there?
I'm not sure, though, on other potential side effects. Maybe we would also need
to change `Import.readFields` to stay aligned with HBASE-18649 (I guess we
could use `CellBuilder` to construct a `Cell` directly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
