virajjasani commented on a change in pull request #3238:
URL: https://github.com/apache/hbase/pull/3238#discussion_r628242734
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java
##########
@@ -91,4 +92,12 @@ public void
logRollRequested(WALActionsListener.RollRequestReason reason) {
break;
}
}
+
+ public void postLogRoll(Path oldPath, Path newPath) throws IOException {
Review comment:
nit: remove `throws IOException`?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWAL.java
##########
@@ -129,4 +136,25 @@ public void testPerTableWALMetrics() throws Exception {
assertEquals(i * numIters, tableAppendSize);
}
}
+
+ @Test
+ public void testLogRolls() throws IOException {
Review comment:
same here, IOException is not thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
