apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r628663543
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##########
@@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int rlength,
int flength, int qlength
DeleteColumn((byte)12),
DeleteFamily((byte)14),
+ // Effective maximum is 127 (Byte.MAX_VALUE). We set the high order bit of
the
+ // type byte in the WAL codecs to indicate, in a backwards compatible way,
if the
+ // value is compressed there.
+ EffectiveMaximum((byte)Byte.MAX_VALUE),
Review comment:
This is the one ugly thing about the trick I use to encode whether or
not a value is compressed in a fully backwards compatible way. I'm not sure if
anything need be done with `Maximum` below. It is no longer a valid value.
Because we overload the high order bit the max KV type value is 127 after this
change.
Of course, as I am proposing this change, I think it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
