[
https://issues.apache.org/jira/browse/HBASE-25850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341382#comment-17341382
]
Hudson commented on HBASE-25850:
--------------------------------
Results for branch branch-2
[build #245 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/245/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/245/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/245/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/245/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/245/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix spotbugs warnings on branch-2
> ---------------------------------
>
> Key: HBASE-25850
> URL: https://issues.apache.org/jira/browse/HBASE-25850
> Project: HBase
> Issue Type: Bug
> Components: Compaction, findbugs, mob
> Reporter: Duo Zhang
> Assignee: Xiao Zhang
> Priority: Major
> Labels: beginner, trivial
> Fix For: 2.5.0
>
>
> {noformat}
> Dodgy code Warnings
> Code Warning
> UC Useless condition: it's known that major == true at this point
> Bug type UC_USELESS_CONDITION (click for details)
> In class org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor
> In method
> org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(Compactor$FileDetails,
> InternalScanner, CellSink, long, boolean, ThroughputController, boolean, int)
> Value major == true
> Unreachable code at DefaultMobStoreCompactor.java:[line 210]
> At DefaultMobStoreCompactor.java:[line 210]
> {noformat}
> https://github.com/apache/hbase/blob/afa9836b87f9c909ac4fc18d904a5b5b0a3dfff6/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L211
> {code}
> if (major) {
> try {
> delFileWriter = mobStore.createDelFileWriterInTmp(new
> Date(fd.latestPutTs),
> fd.maxKeyCount, major ? majorCompactionCompression :
> minorCompactionCompression,
> store.getRegionInfo().getStartKey());
> } catch (IOException e) {
> LOG.warn(
> "Failed to create del writer, "
> + "we will continue the compaction by writing delete markers
> directly in store files",
> e);
> }
> }
> {code}
> The 'major ? majorCompactionCompression : minorCompactionCompression' is
> useless as we have a 'if (major)' test above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
