saintstack commented on a change in pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#discussion_r629484122
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1661,17 +1661,19 @@ public boolean balance(boolean force) throws
IOException {
// if hbase:meta region is in transition, result of assignment cannot
be recorded
// ignore the force flag in that case
boolean metaInTransition =
assignmentManager.isMetaRegionInTransition();
- String prefix = force && !metaInTransition ? "R" : "Not r";
List<RegionStateNode> toPrint = regionsInTransition;
int max = 5;
boolean truncated = false;
if (regionsInTransition.size() > max) {
toPrint = regionsInTransition.subList(0, max);
truncated = true;
}
- LOG.info(prefix + " not running balancer because " +
regionsInTransition.size() +
- " region(s) in transition: " + toPrint + (truncated? "(truncated
list)": ""));
- if (!force || metaInTransition) return false;
+ if (!force || metaInTransition) {
+ LOG.info("Not running balancer (force=" + force + ", metaRIT=" +
metaInTransition +
+ ") because " + regionsInTransition.size() + " region(s) in
transition: " + toPrint +
+ (truncated? "(truncated list)": ""));
+ return false;
+ }
Review comment:
Yeah, usual balancer messages cut in still....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
