apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837518016
> Is it reasonable to always use the same compressor all the time for WALs? It strikes me that operators make an explicit choice about the compression used in their tables, so maybe they would expect that the compressor used by WALs would follow suit. I know it's not that simple, given that WALs are per host and not per table, so maybe it's something to consider in the future. If this is to be tied to table settings we would have to look up settings per table/CF whenever processing an edit. -1. I don't want to do this. It would be too expensive. I see the goal here as making WALs not so terribly un-efficient to keep around. One pass of a standard compression over the values can achieve that, especially when we drop values that don't compress. Speed is important so BEST_SPEED is the right choice for compression level always. Enabling or disabling compression is enough configuration to give to users. This is what we have given them up to now. Now they can turn on or off value compression too. Arguably zlib compression level here is not a user serviceable setting but I could be convinced to at least make that a site configuration setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
