apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629779580
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##########
@@ -34,21 +36,49 @@
@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC,
HBaseInterfaceAudience.PHOENIX})
public class CompressionContext {
- static final String ENABLE_WAL_TAGS_COMPRESSION =
+ public static final String ENABLE_WAL_TAGS_COMPRESSION =
Review comment:
Sorry, these need to be public.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitValueCompression.java:[42,37]
ENABLE_WAL_VALUE_COMPRESSION is not public in
org.apache.hadoop.hbase.regionserver.wal.CompressionContext; cannot be accessed
from outside package
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##########
@@ -34,21 +36,49 @@
@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC,
HBaseInterfaceAudience.PHOENIX})
public class CompressionContext {
- static final String ENABLE_WAL_TAGS_COMPRESSION =
+ public static final String ENABLE_WAL_TAGS_COMPRESSION =
Review comment:
Sorry, these need to be public.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitValueCompression.java:[42,37]
ENABLE_WAL_VALUE_COMPRESSION is not public in
org.apache.hadoop.hbase.regionserver.wal.CompressionContext; cannot be accessed
from outside package
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##########
@@ -34,21 +36,49 @@
@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC,
HBaseInterfaceAudience.PHOENIX})
public class CompressionContext {
- static final String ENABLE_WAL_TAGS_COMPRESSION =
+ public static final String ENABLE_WAL_TAGS_COMPRESSION =
Review comment:
Sorry, these need to be public.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitValueCompression.java:[42,37]
ENABLE_WAL_VALUE_COMPRESSION is not public in
org.apache.hadoop.hbase.regionserver.wal.CompressionContext; cannot be accessed
from outside package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
