Apache9 commented on a change in pull request #3248:
URL: https://github.com/apache/hbase/pull/3248#discussion_r629929132
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -53,6 +52,10 @@
* The base class for load balancers. It provides the the functions used to by
* {@code AssignmentManager} to assign regions in the edge cases. It doesn't
provide an
* implementation of the actual balancing algorithm.
+ * <p/>
+ * Since 3.0.0, all the balancers will be wrapped inside a {@code
RSGroupBasedLoadBalancer}, it will
+ * be in charge of the synchronization of balancing and configuration
changing, so we do not need to
+ * synchronized by ourselves.
Review comment:
It is because a previous work, where we move rsgroup feature to core
hbase instead of using coprocessor.
See HBASE-22514.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
