Apache9 commented on a change in pull request #3202: URL: https://github.com/apache/hbase/pull/3202#discussion_r631623181
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SwitchCompactionOffloadProcedure.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.procedure; + +import java.io.IOException; +import org.apache.hadoop.hbase.ServerName; +import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer; +import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException; +import org.apache.hadoop.hbase.procedure2.ProcedureUtil; +import org.apache.hadoop.hbase.procedure2.ProcedureYieldException; +import org.apache.hadoop.hbase.procedure2.StateMachineProcedure; +import org.apache.hadoop.hbase.regionserver.CompactionOffloadSwitchStorage; +import org.apache.hadoop.hbase.util.RetryCounter; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.SwitchCompactionOffloadState; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.SwitchCompactionOffloadStateData; +import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos; + +/** + * The procedure to switch compaction offload + */ [email protected] +public class SwitchCompactionOffloadProcedure Review comment: The code is almost a clone of SwitchRpcThrottleProcedure, is it possible make a common parent class for these two classes? ########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/compaction/CompactionOffloadManager.java ########## @@ -0,0 +1,134 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.compaction; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; + +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.ServerMetrics; +import org.apache.hadoop.hbase.ServerName; +import org.apache.hadoop.hbase.master.MasterServices; +import org.apache.hadoop.hbase.master.procedure.ProcedurePrepareLatch; +import org.apache.hadoop.hbase.master.procedure.SwitchCompactionOffloadProcedure; +import org.apache.hadoop.hbase.regionserver.CompactionOffloadSwitchStorage; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hbase.thirdparty.com.google.common.cache.Cache; +import org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.IsCompactionOffloadEnabledRequest; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.IsCompactionOffloadEnabledResponse; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.SwitchCompactionOffloadRequest; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.SwitchCompactionOffloadResponse; + [email protected] +public class CompactionOffloadManager { + private final MasterServices masterServices; + /** Map of registered servers to their current load */ + private final Cache<ServerName, ServerMetrics> onlineServers; + private CompactionOffloadSwitchStorage compactionOffloadSwitchStorage; + private static final Logger LOG = + LoggerFactory.getLogger(CompactionOffloadManager.class.getName()); + + public CompactionOffloadManager(final MasterServices master) { + this.masterServices = master; + int compactionServerMsgInterval = + master.getConfiguration().getInt(HConstants.COMPACTION_SERVER_MSG_INTERVAL, 3 * 1000); + int compactionServerExpiredFactor = + master.getConfiguration().getInt("hbase.compaction.server.expired.factor", 2); + this.onlineServers = CacheBuilder.newBuilder().expireAfterWrite( + compactionServerMsgInterval * compactionServerExpiredFactor, TimeUnit.MILLISECONDS).build(); + this.compactionOffloadSwitchStorage = new CompactionOffloadSwitchStorage( + masterServices.getZooKeeper(), masterServices.getConfiguration()); + } + + public void compactionServerReport(ServerName sn, ServerMetrics sl) { + this.onlineServers.put(sn, sl); + } + + /** + * @return A copy of the internal list of online servers. + */ + public List<ServerName> getOnlineServersList() { + return new ArrayList<>(this.onlineServers.asMap().keySet()); + } + + /** + * @return Read-only map of servers to serverinfo + */ + public Map<ServerName, ServerMetrics> getOnlineServers() { + return Collections.unmodifiableMap(this.onlineServers.asMap()); + } + + /** + * May return "0.0.0" when server is not online + */ + public String getVersion(ServerName serverName) { + ServerMetrics serverMetrics = onlineServers.asMap().get(serverName); + return serverMetrics != null ? serverMetrics.getVersion() : "0.0.0"; + } + + public int getInfoPort(ServerName serverName) { + ServerMetrics serverMetrics = onlineServers.asMap().get(serverName); + return serverMetrics != null ? serverMetrics.getInfoServerPort() : 0; + } + + public IsCompactionOffloadEnabledResponse + isCompactionOffloadEnabled(IsCompactionOffloadEnabledRequest request) throws IOException { + masterServices.getMasterCoprocessorHost().preIsCompactionOffloadEnabled(); + boolean enabled = compactionOffloadSwitchStorage.isCompactionOffloadEnabled(); + IsCompactionOffloadEnabledResponse response = IsCompactionOffloadEnabledResponse.newBuilder() + .setCompactionOffloadEnabled(enabled).build(); + masterServices.getMasterCoprocessorHost().postIsCompactionOffloadEnabled(enabled); + return response; + } + + public SwitchCompactionOffloadResponse + switchCompactionOffload(SwitchCompactionOffloadRequest request) throws IOException { + boolean compactionOffloadEnabled = request.getCompactionOffloadEnabled(); + masterServices.getMasterCoprocessorHost().preSwitchCompactionOffload(compactionOffloadEnabled); + boolean oldCompactionOffloadEnable = + compactionOffloadSwitchStorage.isCompactionOffloadEnabled(); + if (compactionOffloadEnabled != oldCompactionOffloadEnable) { Review comment: Should we add this check in the procedure implementation? ########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SwitchCompactionOffloadProcedure.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.procedure; + +import java.io.IOException; +import org.apache.hadoop.hbase.ServerName; +import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer; +import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException; +import org.apache.hadoop.hbase.procedure2.ProcedureUtil; +import org.apache.hadoop.hbase.procedure2.ProcedureYieldException; +import org.apache.hadoop.hbase.procedure2.StateMachineProcedure; +import org.apache.hadoop.hbase.regionserver.CompactionOffloadSwitchStorage; +import org.apache.hadoop.hbase.util.RetryCounter; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.SwitchCompactionOffloadState; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.SwitchCompactionOffloadStateData; +import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos; + +/** + * The procedure to switch compaction offload + */ [email protected] +public class SwitchCompactionOffloadProcedure + extends StateMachineProcedure<MasterProcedureEnv, SwitchCompactionOffloadState> + implements ServerProcedureInterface { + + private static Logger LOG = LoggerFactory.getLogger(SwitchCompactionOffloadProcedure.class); + + private CompactionOffloadSwitchStorage compactionOffloadSwitchStorage; + private boolean CompactionOffloadEnabled; + private ProcedurePrepareLatch syncLatch; + private ServerName serverName; + private RetryCounter retryCounter; + + public SwitchCompactionOffloadProcedure() { + } + + public SwitchCompactionOffloadProcedure( + CompactionOffloadSwitchStorage compactionOffloadSwitchStorage, + boolean CompactionOffloadEnabled, ServerName serverName, + final ProcedurePrepareLatch syncLatch) { + this.compactionOffloadSwitchStorage = compactionOffloadSwitchStorage; + this.syncLatch = syncLatch; + this.CompactionOffloadEnabled = CompactionOffloadEnabled; + this.serverName = serverName; + } + + @Override + protected Flow executeFromState(MasterProcedureEnv env, SwitchCompactionOffloadState state) + throws ProcedureSuspendedException, ProcedureYieldException, InterruptedException { + switch (state) { + case UPDATE_SWITCH_COMPACTION_OFFLOAD_STORAGE: + try { + switchThrottleState(env, CompactionOffloadEnabled); + } catch (IOException e) { + if (retryCounter == null) { + retryCounter = ProcedureUtil.createRetryCounter(env.getMasterConfiguration()); + } + long backoff = retryCounter.getBackoffTimeAndIncrementAttempts(); + LOG.warn("Failed to store compaction offload value {}, sleep {} secs and retry", + CompactionOffloadEnabled, backoff / 1000, e); + setTimeout(Math.toIntExact(backoff)); + setState(ProcedureProtos.ProcedureState.WAITING_TIMEOUT); + skipPersistence(); + throw new ProcedureSuspendedException(); + } + setNextState(SwitchCompactionOffloadState.SWITCH_COMPACTION_OFFLOAD_ON_RS); + return Flow.HAS_MORE_STATE; + case SWITCH_COMPACTION_OFFLOAD_ON_RS: + SwitchCompactionOffloadRemoteProcedure[] subProcedures = + env.getMasterServices().getServerManager().getOnlineServersList().stream() + .map(sn -> new SwitchCompactionOffloadRemoteProcedure(sn, CompactionOffloadEnabled)) + .toArray(SwitchCompactionOffloadRemoteProcedure[]::new); + addChildProcedure(subProcedures); + setNextState(SwitchCompactionOffloadState.POST_SWITCH_COMPACTION_OFFLOAD); + return Flow.HAS_MORE_STATE; + case POST_SWITCH_COMPACTION_OFFLOAD: + ProcedurePrepareLatch.releaseLatch(syncLatch, this); + return Flow.NO_MORE_STATE; + default: + throw new UnsupportedOperationException("unhandled state=" + state); + } + } + + @Override + protected void rollbackState(MasterProcedureEnv env, SwitchCompactionOffloadState state) Review comment: Not implemented? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
