ndimiduk commented on a change in pull request #3249:
URL: https://github.com/apache/hbase/pull/3249#discussion_r632092710
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -487,15 +487,6 @@
final static String UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY =
"hbase.unsafe.regionserver.hostname.disable.master.reversedns";
- /**
- * HBASE-24667: This config
hbase.regionserver.hostname.disable.master.reversedns will be replaced by
Review comment:
The original author made an effort to document that this deprecation
happened as part of HBASE-24667, please preserve this in a comment adjacent to
the config's `DeprecationDelta`.
##########
File path: src/main/asciidoc/_chapters/offheap_read_write.adoc
##########
@@ -165,12 +165,6 @@ because of
link:https://issues.apache.org/jira/browse/HBASE-22532[HBASE-22532].
The three config keys -- `hbase.ipc.server.reservoir.enabled`,
`hbase.ipc.server.reservoir.initial.buffer.size` and
`hbase.ipc.server.reservoir.initial.max` -- introduced in hbase-2.x
have been renamed and deprecated in hbase-3.x/hbase-2.3.x. Please use the new
config keys instead:
`hbase.server.allocator.pool.enabled`, `hbase.server.allocator.buffer.size`
and `hbase.server.allocator.max.buffer.count`.
-If you still use the deprecated three config keys in hbase-3.x, you will get a
WARN log message like:
Review comment:
Good catch!
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java
##########
@@ -92,20 +92,6 @@
@Deprecated
static final String DEPRECATED_BUFFER_SIZE_KEY =
"hbase.ipc.server.reservoir.initial.buffer.size";
- /**
- * The hbase.ipc.server.reservoir.initial.max and
hbase.ipc.server.reservoir.initial.buffer.size
- * were introduced in HBase2.0.0, while in HBase3.0.0 the two config keys
will be replaced by
- * {@link ByteBuffAllocator#MAX_BUFFER_COUNT_KEY} and {@link
ByteBuffAllocator#BUFFER_SIZE_KEY}.
- * Also the hbase.ipc.server.reservoir.enabled will be replaced by
- * hbase.server.allocator.pool.enabled. Keep the three old config keys here
for HBase2.x
- * compatibility.
- */
Review comment:
The original author made an effort to document that this deprecation
happened as part of v2.0.0, so please preserve this in a comment adjacent to
the config's `DeprecationDelta`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
