ndimiduk commented on a change in pull request #3063:
URL: https://github.com/apache/hbase/pull/3063#discussion_r632125575
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -1492,7 +1492,12 @@ def update_tdb_from_arg(tdb, arg)
tdb.setMergeEnabled(JBoolean.valueOf(arg.delete(TableDescriptorBuilder::MERGE_ENABLED)))
if arg.include?(TableDescriptorBuilder::MERGE_ENABLED)
tdb.setNormalizationEnabled(JBoolean.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZATION_ENABLED)))
if arg.include?(TableDescriptorBuilder::NORMALIZATION_ENABLED)
tdb.setNormalizerTargetRegionCount(JInteger.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_COUNT)))
if arg.include?(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_COUNT)
-
tdb.setNormalizerTargetRegionSize(JLong.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_SIZE)))
if arg.include?(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_SIZE)
+ # TODO: Keeping backward compatability for NORMALIZER_TARGET_REGION_SIZE
with HBASE-25651 change. Can be removed in later version
+ if arg.include?(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_SIZE)
+ puts 'Use of NORMALIZER_TARGET_REGION_SIZE has been deprecated and
will be removed in future version, please use NORMALIZER_TARGET_REGION_SIZE_MB
instead'
Review comment:
Is `puts` the right way to communicate to a user? Shouldn't we at least
write to stderr instead of stdout?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
##########
@@ -172,9 +172,9 @@
new Bytes(Bytes.toBytes(NORMALIZER_TARGET_REGION_COUNT));
@InterfaceAudience.Private
- public static final String NORMALIZER_TARGET_REGION_SIZE =
"NORMALIZER_TARGET_REGION_SIZE";
+ public static final String NORMALIZER_TARGET_REGION_SIZE_MB =
"NORMALIZER_TARGET_REGION_SIZE_MB";
Review comment:
I think you have not retained support for the old key. I expected to see
both `"NORMALIZER_TARGET_REGION_SIZE"` and `"NORMALIZER_TARGET_REGION_SIZE_MB"`
used in the method `getNormalizerTargetRegionSize()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
