Apache9 commented on a change in pull request #3268:
URL: https://github.com/apache/hbase/pull/3268#discussion_r633416141
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
##########
@@ -76,7 +76,7 @@
private MasterServices masterServices;
private FavoredNodesManager favoredNodesManager;
private volatile RSGroupInfoManager rsGroupInfoManager;
- private LoadBalancer internalBalancer;
+ private volatile LoadBalancer internalBalancer;
Review comment:
In general, no.
But this is also a fix on the balancer implementation and this patch will be
applied to all active branches I believe, so I think it is OK to also include
these minor changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
