shahrs87 commented on a change in pull request #3277:
URL: https://github.com/apache/hbase/pull/3277#discussion_r635258171
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -1565,49 +1569,23 @@ Path closeWriter(String encodedRegionName,
WriterAndPath wap, List<IOException>
private List<IOException> closeLogWriters(List<IOException> thrown) throws
IOException {
- if (writersClosed) {
- return thrown;
- }
-
if (thrown == null) {
thrown = Lists.newArrayList();
}
- try {
- for (WriterThread t : writerThreads) {
- while (t.isAlive()) {
- t.shouldStop = true;
- t.interrupt();
- try {
- t.join(10);
- } catch (InterruptedException e) {
- IOException iie = new InterruptedIOException();
- iie.initCause(e);
- throw iie;
- }
- }
- }
- } finally {
- WriterAndPath wap = null;
- for (SinkWriter tmpWAP : writers.values()) {
+
+ for (WriterThread t : writerThreads) {
+ while (t.isAlive()) {
+ t.shouldStop = true;
+ t.interrupt();
try {
- wap = (WriterAndPath) tmpWAP;
- wap.w.close();
Review comment:
We are already closing the log files via WALSPlitter#close. Don't know
the context why we are closing it here also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
