shahrs87 commented on a change in pull request #3283:
URL: https://github.com/apache/hbase/pull/3283#discussion_r636069313
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -152,11 +152,12 @@ public void run() {
addBatchToShippingQueue(batch);
}
}
- } catch (IOException e) { // stream related
- if (handleEofException(e, batch)) {
+ } catch (WALEntryFilterRetryableException | IOException e) { // stream
related
+ if (e instanceof IOException && handleEofException((IOException) e,
batch)) {
Review comment:
Instead of adding checks for `e instanceof IOException &&`, we could
change the argument for `handleEofException` to accept Exception instead of
IOException. The very first thing `handleEofException` does is to check
whether `e instance of EOFException or not`. If e is
`WALEntryFilterRetryableException` then it will return false immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
