Apache9 commented on a change in pull request #3279:
URL: https://github.com/apache/hbase/pull/3279#discussion_r636106528
##########
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java
##########
@@ -240,7 +240,7 @@ protected void copyMetaData(FileSystem fs, Path
tmpBackupDir, Path backupDirPath
* @throws IOException exception
*/
protected void copyFile(FileSystem fs, Path p, Path newPath) throws
IOException {
- File f = File.createTempFile("data", "meta");
+ File f = File.createTempFile("data", "meta", new
File(System.getProperty("java.io.tmpdir")));
Review comment:
Why do we need to download the whole file?
Just create an InputStream and an OutputStream and then use IOUtils.copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
