[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

[GitBox]

ZhaoBQ commented on a change in pull request #3063:
URL: https://github.com/apache/hbase/pull/3063#discussion_r637882960



##########
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
##########
@@ -884,7 +891,8 @@ public int getNormalizerTargetRegionCount() {
      */
     @Override
     public long getNormalizerTargetRegionSize() {
-      return getOrDefault(NORMALIZER_TARGET_REGION_SIZE_KEY, Long::valueOf, 
Long.valueOf(-1));
+      long target_region_size = 
getOrDefault(NORMALIZER_TARGET_REGION_SIZE_KEY, Long::valueOf, 
Long.valueOf(-1));
+      return target_region_size == Long.valueOf(-1) ? 
getOrDefault(NORMALIZER_TARGET_REGION_SIZE_MB_KEY, Long::valueOf, 
Long.valueOf(-1)) : target_region_size;

Review comment:
       Get the new configuration first? If both the new and old configurations 
exist, the new configuration value should be the correct value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org