anoopsjohn commented on pull request #3215: URL: https://github.com/apache/hbase/pull/3215#issuecomment-847220592
Ref count is used in all cases now. This has become a part of the ByteBuff which holds the block data. Ya this was added so as to unify the code. We needed refCount at offheap BC. Later we added a way to read into our pooled DBBs when we read from HDFS. So there also ref counting. But then we suffer from perf! Lets take a step back and see what we can do. As such for this issue, the 3 on heap LRU cache having same code in many parts. (mostly copy paste). Only few parts of change like how/what evicted and not aggressive caching. May be its time to refactor it and have an base class. Else we will repeat code everywhere and might miss changes (like this issue) in future. But may be not easy too.. This change, the latest PR I will see tomorrow . tks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
