pankaj72981 commented on a change in pull request #3297:
URL: https://github.com/apache/hbase/pull/3297#discussion_r638171667
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -145,6 +148,10 @@
public static final String RING_BUFFER_SLOT_COUNT =
"hbase.regionserver.wal.disruptor.event.count";
+ public static final String WAL_SHUTDOWN_WAIT_TIMEOUT_MS =
+ "hbase.wal.shutdown.wait.timeout.ms";
+ public static final int DEFAULT_WAL_SHUTDOWN_WAIT_TIMEOUT_MS = 15000;
Review comment:
For readability let's change it to 15 * 1000.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -986,14 +996,43 @@ public void shutdown() throws IOException {
i.logCloseRequested();
}
}
- rollWriterLock.lock();
+
+ ExecutorService shutdownExecutor = Executors.newFixedThreadPool(1,
Review comment:
This will be the second single thread ExecutorService in AbstractFSWAL,
can we do it optimized way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
