[
https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-25933:
-----------------------------------------
Description:
In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries
to log the exception cause message, however this not always will have a
content, causing debugging of connection failure issues harder to troubleshoot.
We should simply log trace the observed *Throwable* reference itself:
{noformat}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
index 1e844bb02cb..40f59ad1259 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
@@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends
ChannelInboundHandlerAdapter {
public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
allChannels.remove(ctx.channel());
NettyRpcServer.LOG.trace("Connection {}; caught unexpected downstream
exception.",
- ctx.channel().remoteAddress(), e.getCause());
+ ctx.channel().remoteAddress(), e);
ctx.channel().close();
}
}
{noformat}
was:
In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries
to log the exception cause message, however this not always will have a
content, causing debugging of connection failure issues harder to
troubleshooting. We should simply log trace the observed *Throwable* reference
itself:
{noformat}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
index 1e844bb02cb..40f59ad1259 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
@@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends
ChannelInboundHandlerAdapter {
public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
allChannels.remove(ctx.channel());
NettyRpcServer.LOG.trace("Connection {}; caught unexpected downstream
exception.",
- ctx.channel().remoteAddress(), e.getCause());
+ ctx.channel().remoteAddress(), e);
ctx.channel().close();
}
}
{noformat}
> Log trace raw exception, instead of cause message in
> NettyRpcServerRequestDecoder
> ---------------------------------------------------------------------------------
>
> Key: HBASE-25933
> URL: https://issues.apache.org/jira/browse/HBASE-25933
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha-1, 2.2.7, 2.3.5, 2.4.3
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Minor
>
> In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries
> to log the exception cause message, however this not always will have a
> content, causing debugging of connection failure issues harder to
> troubleshoot. We should simply log trace the observed *Throwable* reference
> itself:
>
> {noformat}
> diff --git
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
>
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> index 1e844bb02cb..40f59ad1259 100644
> ---
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> +++
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> @@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends
> ChannelInboundHandlerAdapter {
> public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
> allChannels.remove(ctx.channel());
> NettyRpcServer.LOG.trace("Connection {}; caught unexpected downstream
> exception.",
> - ctx.channel().remoteAddress(), e.getCause());
> + ctx.channel().remoteAddress(), e);
> ctx.channel().close();
> }
> }
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
