[ 
https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353324#comment-17353324
 ] 

Hudson commented on HBASE-25933:
--------------------------------

Results for branch master
        [build #307 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/307/]:
 (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/307/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/307/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/307/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Log trace raw exception, instead of cause message in 
> NettyRpcServerRequestDecoder
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-25933
>                 URL: https://issues.apache.org/jira/browse/HBASE-25933
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-1, 2.2.7, 2.5.0, 2.3.5, 2.4.3
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries 
> to log the exception cause message, however this not always will have a 
> content, causing debugging of connection failure issues harder to 
> troubleshoot. We should simply log trace the observed *Throwable* reference 
> itself:
>  
> {noformat}
> diff --git 
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
>  
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> index 1e844bb02cb..40f59ad1259 100644
> --- 
> a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> +++ 
> b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
> @@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends 
> ChannelInboundHandlerAdapter {
>    public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
>      allChannels.remove(ctx.channel());
>      NettyRpcServer.LOG.trace("Connection {}; caught unexpected downstream 
> exception.",
> -        ctx.channel().remoteAddress(), e.getCause());
> +        ctx.channel().remoteAddress(), e);
>      ctx.channel().close();
>    }
>  }
>  {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to