Apache-HBase commented on pull request #3340: URL: https://github.com/apache/hbase/pull/3340#issuecomment-850844584
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotbugs | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | compile | 0m 37s | the patch passed | | -0 :warning: | javac | 0m 37s | hbase-backup generated 2 new + 74 unchanged - 5 fixed = 76 total (was 79) | | -0 :warning: | checkstyle | 0m 15s | hbase-backup: The patch generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 0m 55s | hbase-backup generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 14s | The patch generated 1 ASF License warnings. | | | | 38m 24s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-backup | | | Dead store to addressToLastBackupMap in org.apache.hadoop.hbase.backup.master.BackupLogCleaner.getDeletableFiles(Iterable) At BackupLogCleaner.java:org.apache.hadoop.hbase.backup.master.BackupLogCleaner.getDeletableFiles(Iterable) At BackupLogCleaner.java:[line 148] | | | Dead store to tableToLastBackupMap in org.apache.hadoop.hbase.backup.master.BackupLogCleaner.getDeletableFiles(Iterable) At BackupLogCleaner.java:org.apache.hadoop.hbase.backup.master.BackupLogCleaner.getDeletableFiles(Iterable) At BackupLogCleaner.java:[line 149] | | | org.apache.hadoop.hbase.backup.master.BackupLogCleaner.getServersToOldestBackupMapping(Map) makes inefficient use of keySet iterator instead of entrySet iterator At BackupLogCleaner.java:keySet iterator instead of entrySet iterator At BackupLogCleaner.java:[line 124] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3340 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 114877a8c961 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9a2027bf71 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-backup.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/artifact/yetus-general-check/output/new-spotbugs-hbase-backup.html | | asflicense | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 96 (vs. ulimit of 30000) | | modules | C: hbase-backup U: hbase-backup | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3340/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
