Apache9 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r642075774
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/StartMiniClusterOption.java
##########
@@ -76,6 +76,11 @@
*/
private Class<? extends MiniHBaseCluster.MiniHBaseClusterRegionServer>
rsClass;
+ /**
+ * Number of compaction servers to start up.
+ */
+ private final int numCompactionServers;
Review comment:
Why final?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
##########
@@ -122,7 +170,7 @@ public HMaster getMaster() {
* @param c Configuration to use.
* @param hmc Class to create.
* @param index Used distinguishing the object returned.
- * @throws IOException
+ * @throws IOException throw IOException
Review comment:
Just remove this line if nothing need to be documented?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -101,16 +102,17 @@ public MiniHBaseCluster(Configuration conf, int
numMasters, int numRegionServers
* @throws InterruptedException
*/
public MiniHBaseCluster(Configuration conf, int numMasters, int
numAlwaysStandByMasters,
- int numRegionServers, List<Integer> rsPorts, Class<? extends HMaster>
masterClass,
- Class<? extends MiniHBaseCluster.MiniHBaseClusterRegionServer>
regionserverClass)
+ int numRegionServers, List<Integer> rsPorts, int numCompactionServers,
Review comment:
This class is marked as IA.Public, so you need to keep all the old
constructors...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
