[ 
https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355594#comment-17355594
 ] 

Duo Zhang commented on HBASE-25960:
-----------------------------------

I generated 3.5.1RC0 with the docker based create-release scripts, this is what 
I got for netty native libraries

{noformat}
zhangduo@zhangduo-ubuntu:~/hbase/thirdparty-3.5.1RC0/output/hbase-thirdparty/hbase-shaded-netty/target/aaa/META-INF/native$
 ll -rth
总用量 336K
-rw-r--r-- 1 zhangduo zhangduo  91K 5月  19 12:24 
liborg_apache_hbase_thirdparty_netty_transport_native_epoll_aarch_64.so
-rw-r--r-- 1 zhangduo zhangduo  85K 5月  19 12:25 
liborg_apache_hbase_thirdparty_netty_transport_native_epoll_x86_64.so
-rw-r--r-- 1 zhangduo zhangduo  76K 5月  19 14:49 
libnetty_transport_native_kqueue_x86_64.jnilib
-rw-r--r-- 1 zhangduo zhangduo  72K 5月  19 14:50 
libnetty_resolver_dns_native_macos_x86_64.jnilib
drwxr-xr-x 2 zhangduo zhangduo 4.0K 6月   2 06:08 ./
drwxr-xr-x 5 zhangduo zhangduo 4.0K 6月   2 06:08 ../
{noformat}

I think the problem is we also need to relocate the native libraries for mac, 
but I haven't seen unrelocated so libraries...

Let me open an issue for also relocating mac libraries.

> Build includes unshaded netty .so; clashes w/ downstreamers who would use a 
> different version of netty
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-25960
>                 URL: https://issues.apache.org/jira/browse/HBASE-25960
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Michael Stack
>            Priority: Major
>
> A coworker was trying to use hbase client in a fat application that uses a 
> different netty version to what hbase uses internally. Their app would fail 
> to launch because it kept bumping into an incompatible netty .so lib. Here 
> are the unshaded netty .so's we bundle looking at hbase-2.4.1...:
> ./lib/hbase-shaded-netty-3.4.1.jar has:
> {code}
> META-INF/native/libnetty_transport_native_epoll_aarch_64.so
> META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_x86_64.so
> META-INF/native/libnetty_transport_native_epoll_x86_64.so
> {code}
> (HBASE-25959 should fix the non-relocation of 
> libnetty_transport_native_epoll_aarch_64).
> ./lib/shaded-clients/hbase-shaded-client-byo-hadoop-2.4.1.1-apple.jar has the 
> same three .sos as does 
> ./lib/shaded-clients/hbase-shaded-mapreduce-2.4.1.1-apple.jar
> and ./lib/shaded-clients/hbase-shaded-client-2.4.1.1-apple.jar
> We even bundle ./lib/netty-all-4.1.17.Final.jar which unsurprisingly has the 
> netty .sos in it.
> Looking at published builds of hbase-thirdparty, I see that these too include 
> the above trio of .sos... The hbase-shaded-netty includes them in 3.4.1 
> https://repo1.maven.org/maven2/org/apache/hbase/thirdparty/hbase-shaded-netty/3.4.1/
>  as does 3.5.0.
> I just tried running a build of hbase-thirdparty and it does NOT include the 
> extras....
> META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_aarch_64.so
> META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_x86_64.so
> (it has the fix for aarch included... when I built)
> Here is link to the snapshot I made:
> https://repository.apache.org/content/repositories/orgapachehbase-1451/org/apache/hbase/thirdparty/hbase-shaded-netty/3.5.1-stack4/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to