ndimiduk commented on pull request #3349:
URL: https://github.com/apache/hbase/pull/3349#issuecomment-853416924


   Trying to interpret this output. I think our build is configured such that 
the only module that bundles bootstrap is hbase-server. However, I think we 
also bundle it in hbase-thrift.
   
   ```
   $ git grep bundled-bootstrap
   hbase-assembly/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   hbase-http/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   
hbase-resource-bundle/src/main/resources/META-INF/NOTICE.vm:#set($bundled-bootstrap
 = ${bundled-bootstrap.equalsIgnoreCase("true")})
   
hbase-resource-bundle/src/main/resources/META-INF/NOTICE.vm:#if($bundled-bootstrap
 || $bundled-logo || $bundled-dependencies)
   
hbase-resource-bundle/src/main/resources/META-INF/NOTICE.vm:#if(${bundled-bootstrap})
   hbase-server/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   hbase-shaded/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   ```
   
   ```
   $ git grep license.bundles.bootstrap
   hbase-assembly/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   hbase-http/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   hbase-server/pom.xml:    
<license.bundles.bootstrap>true</license.bundles.bootstrap>
   hbase-server/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   hbase-shaded/pom.xml:                
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
   pom.xml:    <license.bundles.bootstrap>false</license.bundles.bootstrap>
   ```
   
   ```
   $ find . -ipath '*/src/*' -iname '*bootstrap*'
   ./hbase-thrift/src/main/resources/hbase-webapps/static/css/bootstrap.min.css
   
./hbase-thrift/src/main/resources/hbase-webapps/static/css/bootstrap-theme.min.css
   ./hbase-thrift/src/main/resources/hbase-webapps/static/js/bootstrap.min.js
   ./hbase-server/src/main/resources/hbase-webapps/static/css/bootstrap.min.css
   
./hbase-server/src/main/resources/hbase-webapps/static/css/bootstrap-theme.min.css
   ./hbase-server/src/main/resources/hbase-webapps/static/js/bootstrap.min.js
   ./hbase-shell/src/main/ruby/jar-bootstrap.rb
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to