bharathv commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858748709
> Should there be bounds on the cache size? There doesn't seem to be any. Good point, I can add a limit but practically it doesn't matter, I think. We only grow as many as handler threads (and some extra for temporary operations) which should be low thousands and we already have "expireAfterAccess" set to 2mins, so the cache should be GC-ed automatically. I'll still add a max limit, just in case. > I do wonder about all threads contending on the cache object (where, IIRC, there was on coordination before). Cache is keyed by the Thread object using the future. So the contention scope is the cache key but there is only a single thread using a sync future at any point in time, so in effect I think there is no contention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
