GeorryHuang commented on a change in pull request #3374:
URL: https://github.com/apache/hbase/pull/3374#discussion_r650395099
##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -313,7 +314,12 @@
for (int j = 0; j < numMetaReplicas; j++) {
RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
RegionInfoBuilder.FIRST_META_REGIONINFO,
j);
- ServerName metaLocation =
MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+ ServerName metaLocation = null;
+ try {
+ metaLocation =
MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+ } catch (NotAllMetaRegionsOnlineException e) {
+ //Should ignore this Exception for we don't need to display rit
meta region info in UI
Review comment:
Ok! Thansk for your comments
##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -378,7 +389,17 @@
for (int j = 0; j < numMetaReplicas; j++) {
RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
RegionInfoBuilder.FIRST_META_REGIONINFO,
j);
- ServerName metaLocation =
MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+ //If a metaLocation is null, All of its info would be empty here
to be displayed.
+ ServerName metaLocation = null;
+ try {
+ metaLocation =
MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+ } catch (NotAllMetaRegionsOnlineException e) {
+ //Since a region in transition state throw a
NotAllMetaRegionsOnlineException then
Review comment:
@Apache9 What about this explanation here? By the way, I added a
'continue' here to skip to display rit region. IMHO, we do not need to show
region info here since the home page of master status UI has show which region
is in transition and why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
