[
https://issues.apache.org/jira/browse/HBASE-25391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362823#comment-17362823
]
Wellington Chevreuil commented on HBASE-25391:
----------------------------------------------
{quote}
Wellington Chevreuil Asked for a RN because the parent was partly done then put
aside. It was then picked up, so trying to follow what is being added now.
{quote}
Sure, I will add it to the subsequent tasks.
{quote}
One (too-late) comment is that the name 'PersistedEngineStoreFlusher' seems
odd. Its a flusher – an action – but its 'persisted' which is a final state...
the two parts of the name argue w/ each other. Then, when would we do a store
flusher that did not 'persist'? Should it be DirectStoreFlusherEngine and
DirectStoreFlushContext – i.e. no intermediate (indirect) tmp file?
{quote}
Yeah, I tried to keep the "persisted" prefix to try make some connection with
the original jira namings, but it sounds confusing indeed. I'm working on a PR
for HBASE-25392, can I do this renaming there?
> Flush directly into data directory, skip rename when committing flush
> ---------------------------------------------------------------------
>
> Key: HBASE-25391
> URL: https://issues.apache.org/jira/browse/HBASE-25391
> Project: HBase
> Issue Type: Sub-task
> Reporter: Tak-Lon (Stephen) Wu
> Assignee: Wellington Chevreuil
> Priority: Major
>
> {color:#000000}When flushing memstore snapshot to HFile, we write it directly
> to the data directory.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
