Apache9 commented on a change in pull request #3421:
URL: https://github.com/apache/hbase/pull/3421#discussion_r657709438
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java
##########
@@ -453,9 +453,14 @@ void flushInMemory() {
inMemoryCompaction();
}
- private void flushInMemory(MutableSegment currActive) {
+ protected void flushInMemory(MutableSegment currActive) {
LOG.trace("IN-MEMORY FLUSH: Pushing active segment into compaction
pipeline");
- pushActiveToPipeline(currActive);
+ // NOTE: Due to concurrent writes and because we first add cell size to
currActive.getDataSize
Review comment:
Do we need synchronization here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
