rahulLiving commented on a change in pull request #3402:
URL: https://github.com/apache/hbase/pull/3402#discussion_r658867473



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1401,7 +1401,7 @@ public OfflineRegionResponse offlineRegion(RpcController 
controller,
         master.cpHost.preRegionOffline(hri);
       }
       LOG.info(master.getClientIdAuditPrefix() + " offline " + 
hri.getRegionNameAsString());
-      master.assignmentManager.regionOffline(hri);
+      master.assignmentManager.regionOffline(hri, true);

Review comment:
       Shouldn't we check for the new state if its `OFFLINE` before forcing it 
to remove ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to