nyl3532016 edited a comment on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869608162
> Please add more javadoc for CompactionServer related class on how to share the same logic with HRegionServer? I do not think we want to duplicate the code twice... `CompactionThreadManager` reuse `HStore.selectCompaction`,`HStore.throttleCompaction`,`CompactionContext.compact` of `HRegionserver`, which are core logic of compaction. Yes,we have a few duplicate code, just like compaction thread pool and CompactionRunner. I will try to eliminate thread pool duplicate code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
