virajjasani commented on a change in pull request #3417:
URL: https://github.com/apache/hbase/pull/3417#discussion_r660846981
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -953,9 +956,26 @@ private void
finishActiveMasterInitialization(MonitoredTask status)
if (!waitForMetaOnline()) {
return;
}
+ TableDescriptor metaDescriptor = tableDescriptors.get(
+ TableName.META_TABLE_NAME);
+ final ColumnFamilyDescriptor tableFamilyDesc = metaDescriptor
+ .getColumnFamily(HConstants.TABLE_FAMILY);
+ final ColumnFamilyDescriptor replBarrierFamilyDesc =
+ metaDescriptor.getColumnFamily(HConstants.REPLICATION_BARRIER_FAMILY);
+
this.assignmentManager.joinCluster();
// The below depends on hbase:meta being online.
- this.tableStateManager.start();
+ try {
+ this.tableStateManager.start();
+ } catch (NoSuchColumnFamilyException e) {
+ if (tableFamilyDesc == null && replBarrierFamilyDesc == null) {
Review comment:
This PR is for 2.3+ releases meaning if we come from HBase 1 to 2.3+,
the transition should be seamless. Hence, for this upgrade case, both table and
repl_barrier will be missing.
> When its 2.0.x to 2.3.x upgrade, the repBarrier will get auto created?
I have not tried this one. If table CF is handled, I guess repl_barrier too
would have been handled. As per @saintstack's testing, the cluster had to come
from 1.2 to earlier than 2.3 release and from that release, it went on to 2.3,
hence I am assuming HBase 2 (< 2.3) to 2.3 upgrade should have been smooth.
@saintstack thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
