Apache9 commented on a change in pull request #3436:
URL: https://github.com/apache/hbase/pull/3436#discussion_r663310572
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java
##########
@@ -221,22 +223,25 @@ private boolean matches(Region region,
ClientProtos.Condition condition) throws
get.setTimeRange(timeRange.getMin(), timeRange.getMax());
}
- List<Cell> result = region.get(get, false);
boolean matches = false;
- if (filter != null) {
- if (!result.isEmpty()) {
- matches = true;
- }
- } else {
- boolean valueIsNull = comparator.getValue() == null ||
comparator.getValue().length == 0;
- if (result.isEmpty() && valueIsNull) {
- matches = true;
- } else if (result.size() > 0 && result.get(0).getValueLength() == 0 &&
valueIsNull) {
- matches = true;
- } else if (result.size() == 1 && !valueIsNull) {
- Cell kv = result.get(0);
- int compareResult = PrivateCellUtil.compareValue(kv, comparator);
- matches = matches(op, compareResult);
+ try (RegionScanner scanner = region.getScanner(new Scan(get))) {
+ List<Cell> result = new ArrayList<>();
Review comment:
I think we'd better find a way to fix the get method itself...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
