Apache9 commented on a change in pull request #2984:
URL: https://github.com/apache/hbase/pull/2984#discussion_r664999757
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
##########
@@ -146,6 +147,7 @@ public void testIsFileDeletable() throws IOException,
ReplicationException {
assertFalse("Cleaner should not allow to delete this file as there is a
hfile reference node "
+ "for it in the queue.",
cleaner.isFileDeletable(fs.getFileStatus(file)));
+ rq.removeHFileRefs(peerId,
Arrays.asList("testIsFileDeletableWithNoHFileRefs"));
Review comment:
A potential problem of putting the removal at the end of the test is
that, if the test fail before arriving this line, the HFileRefs will leave
there and may cause later tests to fail. I think it will be better to remove
all HFileRefs in the tearDown method if any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
