nyl3532016 commented on a change in pull request #3464:
URL: https://github.com/apache/hbase/pull/3464#discussion_r667499208
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/compactionserver/TestCompactionServer.java
##########
@@ -277,20 +289,20 @@ public void testCompactionOffloadTableDescriptor() throws
Exception {
TableDescriptor htd =
TableDescriptorBuilder.newBuilder(TEST_UTIL.getAdmin().getDescriptor(TABLENAME))
- .setCompactionOffloadEnabled(true).build();
+ .setCompactionOffloadEnabled(false).build();
TEST_UTIL.getAdmin().modifyTable(htd);
TEST_UTIL.waitUntilAllRegionsAssigned(TABLENAME);
// invoke compact
TEST_UTIL.compact(TABLENAME, false);
- TEST_UTIL.waitFor(6000, () -> COMPACTION_SERVER.requestCount.sum() > 0);
- long requestCount = COMPACTION_SERVER.requestCount.sum();
+ Thread.sleep(1000);
Review comment:
OK,this sleep is no need. My Initially thought is compact request is
async, this sleep will make the check below effective, After view code I find
the increment of request count on compaction server is sync in compaction
request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
