jojochuang commented on a change in pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#discussion_r668066189
##########
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
##########
@@ -1070,7 +1072,13 @@ boolean rollWriter(long logId) throws IOException {
long startPos = -1;
newLogFile = getLogFilePath(logId);
try {
- newStream = CommonFSUtils.createForWal(fs, newLogFile, false);
+ FSDataOutputStreamBuilder<?, ?> builder =
fs.createFile(newLogFile).overwrite(false);
+ if (builder instanceof
DistributedFileSystem.HdfsDataOutputStreamBuilder) {
Review comment:
My only concern is that we would then need to add hadoop-hdfs-client
dependency to hbase-common, and I am not sure if that's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
