Apache-HBase commented on pull request #3488: URL: https://github.com/apache/hbase/pull/3488#issuecomment-880906496
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24749 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | HBASE-24749 passed | | +1 :green_heart: | compile | 3m 12s | HBASE-24749 passed | | +1 :green_heart: | checkstyle | 1m 4s | HBASE-24749 passed | | +1 :green_heart: | spotbugs | 2m 8s | HBASE-24749 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | -1 :x: | compile | 1m 26s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 26s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 30 new + 40 unchanged - 3 fixed = 70 total (was 43) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 19s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 2m 14s | hbase-server generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 45m 23s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-server | | | Dead store to conf in org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure$DefaultMergeStrategy.mergeStoreFiles(MasterProcedureEnv, HRegionFileSystem, Path, RegionInfo) At MergeTableRegionsProcedure.java:org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure$DefaultMergeStrategy.mergeStoreFiles(MasterProcedureEnv, HRegionFileSystem, Path, RegionInfo) At MergeTableRegionsProcedure.java:[line 745] | | | Dead store to mfs in org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure$DefaultMergeStrategy.mergeStoreFiles(MasterProcedureEnv, HRegionFileSystem, Path, RegionInfo) At MergeTableRegionsProcedure.java:org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure$DefaultMergeStrategy.mergeStoreFiles(MasterProcedureEnv, HRegionFileSystem, Path, RegionInfo) At MergeTableRegionsProcedure.java:[line 744] | | | org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitDaughterRegion(RegionInfo) makes inefficient use of keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:[line 234] | | | org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitMergedRegion(RegionInfo) makes inefficient use of keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator At DirectStoreFSWriteStrategy.java:[line 255] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3488 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5f11a5a0bce0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24749 / 49b68b0e00 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 96 (vs. ulimit of 30000) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
