saintstack commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881956862
> To avoid conflict with the copied ones in hbase-testing-util, we should either move the original one to another package, or rename them. In general, I do not have much intention on which one is better, but for me, I do not have better names for these classes, due to lack of English vocabulary... Do you have any suggestions sir? We could move them back to the top level, but with different names. Thanks for explanation. Suggest you add description on the JIRA repeating the helpful overview you give here pointing at the parent issue's discussion. On moving the classes to a sub-package though some of these classes are used broadly, given what you are trying to achieve (cleanup, refactor), this is probably the easiest approach. One suggestion I have would be renaming HBaseTestingUtility as TestingUtility and leaving it in the top-level package. The 'HBase' prefix is redundant. Might be working looking at. If it makes more work for you, just ignore. Meantime, let me +1 this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
