Apache9 commented on a change in pull request #3504:
URL: https://github.com/apache/hbase/pull/3504#discussion_r673204432
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -166,6 +169,9 @@ public void run() {
} catch (InterruptedException e) {
LOG.trace("Interrupted while sleeping between WAL reads or adding WAL
batch to ship queue");
Thread.currentThread().interrupt();
+ } finally {
Review comment:
OK, so if we could move the main logic in WALEntryStream.getArchivedLog
to a util class, then we do not need try finally then? In general, I do not
think we should expose WALEntryStream.getArchivedLog directly. Let's add a
public static method in AbstractFSWALProvider, just below the
getWALArchiveDirectoryName method. I think this is the right place for holding
a public method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
