Reidddddd commented on a change in pull request #3498:
URL: https://github.com/apache/hbase/pull/3498#discussion_r673619465
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -77,8 +77,7 @@ public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf)
{
@Override
public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
boolean repeat, boolean updateCacheMetrics) {
- // TODO: is there a hole here, or just awkwardness since in the lruCache
getBlock
- // we end up calling l2Cache.getBlock.
+ // After HBASE-26094, in CombinedBC L2 cache is not the victim handler of
L1.
Review comment:
unnecessary, better to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
