joshelser commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r674263971
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -278,6 +280,21 @@ protected final StoreFileWriter
createTmpWriter(FileDetails fd, boolean shouldDr
HConstants.EMPTY_STRING);
}
+ /**
+ * Default method for initializing a StoreFileWriter in the compaction
process, this creates the
Review comment:
> What I meant is that other compactors may overwrite the method with a
different logic.
I'm just thinking about what other potential compaction algorithms may
choose to do. I would expect that any future compactions would still want to
leverage the "commit logic" here to avoid that rename. Just keeping tabs on
"pre-optimization" without a specific use-case in mind. Although, as long as
other compaction algorithms can extend DirectStoreCompactor and get the new
shiny solution, it's not a concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
