anoopsjohn commented on a change in pull request #3516:
URL: https://github.com/apache/hbase/pull/3516#discussion_r674541995
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java
##########
@@ -381,7 +388,11 @@ public static Scan extractScanFromConf(Configuration conf)
throws IOException {
boolean localityEnabled =
conf.getBoolean(SNAPSHOT_INPUTFORMAT_LOCALITY_ENABLED_KEY,
SNAPSHOT_INPUTFORMAT_LOCALITY_ENABLED_DEFAULT);
- List<InputSplit> splits = new ArrayList<>();
+ boolean scanMetricsEnabled =
conf.getBoolean(SNAPSHOT_INPUTFORMAT_SCAN_METRICS_ENABLED,
+ SNAPSHOT_INPUTFORMAT_SCAN_METRICS_ENABLED_DEFAULT);
+ scan.setScanMetricsEnabled(scanMetricsEnabled);
+
+ List<InputSplit> splits = new ArrayList<>();
Review comment:
nit : Not proper indentation
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java
##########
@@ -107,6 +107,14 @@
public static final String SNAPSHOT_INPUTFORMAT_ROW_LIMIT_PER_INPUTSPLIT =
"hbase.TableSnapshotInputFormat.row.limit.per.inputsplit";
+ /**
+ * Whether to enable scan metrics on Scan, default to true
+ */
+ public static final String SNAPSHOT_INPUTFORMAT_SCAN_METRICS_ENABLED =
+ "hbase.TableSnapshotInputFormat.scan_metrics_enabled";
Review comment:
Should we name it as scan_metrics.enabled ? That is what normally we do
I believe and I could see many such conf names in code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
