wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r674801406
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -558,18 +559,19 @@ protected InternalScanner createScanner(HStore store,
ScanInfo scanInfo,
* @param cr the compaction request.
* @param newFiles the new files created by this compaction under a temp dir.
* @param user the running user.
+ * @param fileAcessor a lambda expression with logic for loading a
HStoreFile given a Path.
* @return A list of the resulting store files already placed in the store
dir and loaded into the
* store cache.
* @throws IOException if the commit fails.
*/
- public List<HStoreFile> commitCompaction(CompactionRequestImpl cr,
List<Path> newFiles, User user)
- throws IOException {
+ public List<HStoreFile> commitCompaction(CompactionRequestImpl cr,
List<Path> newFiles,
+ User user, Function<Path, HStoreFile> fileAcessor) throws IOException {
Review comment:
Definitely, and can make its method throw IOException too, leaving the
HStore code cleaner. Had just pushed a new commit with it, for now, created as
public inner class of Compactor itself, as it's strictly related to Compactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
