wchevreuil commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-884920162
> I think migrating the Function to some kind of named and documented interface is the only thing I see remaining. Good work, Wellington. I think I'm +1 after this. Yeah, had thought about it previously. Had just added it in the last commit. > > My comment about StripeCompactor and DTCompactor can be deferred, I think. Doesn't need to complicate this further. Agreed. Right now, SC and DTC will only work with the default engine that does temp/rename. We can work later on support direct store for these type of compactions too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
