wchevreuil commented on a change in pull request #3488:
URL: https://github.com/apache/hbase/pull/3488#discussion_r674865197
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
##########
@@ -107,6 +113,21 @@ public MergeTableRegionsProcedure(final MasterProcedureEnv
env,
// Preflight depends on mergedRegion being set (at least).
preflightChecks(env, true);
this.force = force;
+ createMergeStrategy(env.getMasterConfiguration());
+ }
+
+ private void createMergeStrategy(Configuration conf) {
+ String className = conf.get(MERGE_REGION_STRATEGY,
DefaultMergeStrategy.class.getName());
+ createMergeStrategy(className);
+ }
+
+ private void createMergeStrategy(String className) {
Review comment:
Ack
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
##########
@@ -107,6 +113,21 @@ public MergeTableRegionsProcedure(final MasterProcedureEnv
env,
// Preflight depends on mergedRegion being set (at least).
preflightChecks(env, true);
this.force = force;
+ createMergeStrategy(env.getMasterConfiguration());
+ }
+
+ private void createMergeStrategy(Configuration conf) {
+ String className = conf.get(MERGE_REGION_STRATEGY,
DefaultMergeStrategy.class.getName());
+ createMergeStrategy(className);
+ }
+
+ private void createMergeStrategy(String className) {
+ try {
+ LOG.info("instantiating write strategy {}", className);
+ mergeStrategy = (MergeRegionsStrategy)
Class.forName(className).newInstance();
+ } catch (Exception e) {
+ LOG.error("Unable to create write strategy: {}", className, e);
Review comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
