[
https://issues.apache.org/jira/browse/HBASE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283796#comment-13283796
]
Hadoop QA commented on HBASE-6108:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529809/HBASE-6108.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 60 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 33 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSide
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2004//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2004//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2004//console
This message is automatically generated.
> Use HRegion.closeHRegion instead of HRegion.close() and
> HRegion.getLog().close()
> --------------------------------------------------------------------------------
>
> Key: HBASE-6108
> URL: https://issues.apache.org/jira/browse/HBASE-6108
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-6108.patch
>
>
> There are a bunch of places in the code like this:
> region.close();
> region.getLog().closeAndDelete();
> Instead of the better:
> HRegion.closeHRegion(region);
> We should change these for a few reasons:
> 1) If we ever need to change the implementation, it's easier to change in one
> place
> 2) closeHRegion properly checks for nulls. There are a few places where this
> could make a difference, for example in TestOpenedRegionHandler.java it's
> possible that an exception can be thrown before "region" is assigned and thus
> region.close() could throw an NPE. closeHRegion avoids this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
