[
https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385947#comment-17385947
]
Michael Stack commented on HBASE-25792:
---------------------------------------
The revert was not complete... This bit was left over. I just reverted the
below to complete the revert from branch-2.3.
{code:java}
commit 1832418ca7b78739c8443a4a1f3de587e847a41a (HEAD -> 2.3, origin/branch-2.3)
Author: stack <[email protected]>
Date: Thu Jul 22 22:25:36 2021 -0700 Revert "HBASE-25792 Filter out
o.a.hadoop.thirdparty building shaded jars" This reverts commit
59a67c6dfbae00bbf9c7994224b66406260e8f50.diff --git a/hbase-shaded/pom.xml
b/hbase-shaded/pom.xml
index 27e6d3cfd3..615bdb2a99 100644
--- a/hbase-shaded/pom.xml
+++ b/hbase-shaded/pom.xml
@@ -541,13 +541,6 @@
<exclude>keytab.txt</exclude>
</excludes>
</filter>
- <filter>
- <!-- Remove the shaded guava added in
hadoop-3.3.1+-->
- <artifact>*:*</artifact>
- <excludes>
-
<exclude>org/apache/hadoop/thirdparty/**/*</exclude>
- </excludes>
- </filter>
</filters>
</configuration>
</execution> {code}
> Filter out o.a.hadoop.thirdparty building shaded jars
> -----------------------------------------------------
>
> Key: HBASE-25792
> URL: https://issues.apache.org/jira/browse/HBASE-25792
> Project: HBase
> Issue Type: Bug
> Components: shading
> Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3
> Reporter: Michael Stack
> Assignee: Michael Stack
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips
> the check in our shading that tries to exclude hadoop bits from the fat jars
> we build.
> For the issue to trigger, need to build against tip of hadoop branch-3.3. You
> then get this complaint:
> {code}
> [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @
> hbase-shaded-check-invariants ---
> [ERROR] Found artifact with unexpected contents:
> '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> org/apache/hadoop/thirdparty/
> org/apache/hadoop/thirdparty/com/
> org/apache/hadoop/thirdparty/com/google/
> org/apache/hadoop/thirdparty/com/google/common/
> org/apache/hadoop/thirdparty/com/google/common/annotations/
> org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class
>
> org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class
>
> org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class
>
> org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class
> org/apache/hadoop/thirdparty/com/google/common/base/
> org/apache/hadoop/thirdparty/com/google/common/base/Absent.class
>
> org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class
>
> org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class
> org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class
> org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class
> org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class
> org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class
> org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class
> org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class
> ....
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
