Apache-HBase commented on pull request #3488:
URL: https://github.com/apache/hbase/pull/3488#issuecomment-885768803


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 37s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ HBASE-24749 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  HBASE-24749 passed  |
   | +1 :green_heart: |  compile  |   6m  2s |  HBASE-24749 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 50s |  HBASE-24749 passed  |
   | +1 :green_heart: |  spotbugs  |   7m 55s |  HBASE-24749 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 45s |  the patch passed  |
   | -1 :x: |  compile  |   1m 55s |  hbase-server in the patch failed.  |
   | -0 :warning: |  cc  |   1m 55s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   1m 55s |  hbase-server in the patch failed.  |
   | -0 :warning: |  checkstyle  |   1m 31s |  hbase-server: The patch 
generated 32 new + 40 unchanged - 3 fixed = 72 total (was 43)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  20m 19s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 41s |  the patch passed  |
   | -1 :x: |  spotbugs  |   2m 46s |  hbase-server generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 23s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  71m 34s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitDaughterRegion(RegionInfo)
 makes inefficient use of keySet iterator instead of entrySet iterator  At 
DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator  
At DirectStoreFSWriteStrategy.java:[line 233] |
   |  |  
org.apache.hadoop.hbase.regionserver.DirectStoreFSWriteStrategy.commitMergedRegion(RegionInfo)
 makes inefficient use of keySet iterator instead of entrySet iterator  At 
DirectStoreFSWriteStrategy.java:keySet iterator instead of entrySet iterator  
At DirectStoreFSWriteStrategy.java:[line 255] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3488 |
   | Optional Tests | dupname asflicense cc hbaseprotoc prototool javac 
spotbugs hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9f50943ce661 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 
19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-24749 / 49b68b0e00 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | cc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
 |
   | Max. process+thread count | 86 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3488/6/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to