Apache9 commented on a change in pull request #3523:
URL: https://github.com/apache/hbase/pull/3523#discussion_r675911311



##########
File path: 
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtil.java
##########
@@ -40,7 +40,9 @@
 /**
  * Common helpers for testing HBase that do not depend on specific server/etc. 
things.
  */
[email protected](HBaseInterfaceAudience.PHOENIX)
[email protected]({HBaseInterfaceAudience.COPROC,

Review comment:
       I'm not a native English speaker so sorry I can not understand what you 
mean.
   
   What I say compromise here, is in HBASE-13126, we want to mark HBTU as 
IA.Private, but consider the current situation, at least we need to mark it as 
IA.LP("Phoenix"), as we are sure that Phoenix needs to test something internal 
to HBase. This is a compromise.
   
   But if you offer your help on improving the new testing clsuter interface, I 
think maybe we could finish the support for Phoenix before 3.0.0 is out, then 
probably we could mark HBTU as IA.Private in 3.0.0 finally.
   
   Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to