comnetwork commented on a change in pull request #3531:
URL: https://github.com/apache/hbase/pull/3531#discussion_r680293372
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##########
@@ -228,14 +236,15 @@ Chunk getChunk(CompactingMemStore.IndexType
chunkIndexType, int size) {
*/
Chunk getJumboChunk(int jumboSize) {
int allocSize = jumboSize + SIZEOF_CHUNK_HEADER;
- if (allocSize <= dataChunksPool.getChunkSize()) {
+
+ if (allocSize <= this.getChunkSize()) {
Review comment:
Because the `ChunkCreator.dataChunksPool` maybe null(If we disable the
chunk pool), which may throw `NullPointerException`.
`getChunkSize` is actually `getChunkSize(ChunkType.DATA_CHUNK)`, which
considering the case if `ChunkCreator.dataChunksPool` is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
