[
https://issues.apache.org/jira/browse/HBASE-26144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391033#comment-17391033
]
Hudson commented on HBASE-26144:
--------------------------------
Results for branch branch-2
[build #311 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/311//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> The HStore.snapshot method is never called in main code
> -------------------------------------------------------
>
> Key: HBASE-26144
> URL: https://issues.apache.org/jira/browse/HBASE-26144
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> In the comment of HStore.flushCache, we say that HStore.snapshot method must
> be called first. But actually, we will call memstore.snapshot directly from
> StoreFlusherImpl.prepare, without holding the write lock. The reason we do
> not need to hold the write lock is that, we hold HRegion.updatesLock in the
> upper layer, so it is OK.
> See HBASE-10087 for more discussion about this.
> So in general, I think we could remove the snapshot method in HStore. And I
> do not think we need to hold the write lock when calling clearSnapshot then.
> As in the HRegion layer, we need to guarantee that there is only one ongoing
> flush of the region, so before we finish the region, it is already safe to
> operate on the snapshot of the memstore, especially that the clearSnapshot
> method itself is thread safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
